mac fullscreen mode
Posted: Tue Oct 06, 2015 11:15 pm
Hi
I've been looking at what needs to be done to implement fullscreen mode on mac as a hacktoberfest contribution. At first I was just thinking about adding a fullscreenControl property but then I realised it probably should be a decoration. Now I've come to the conclusion that it would be better to implement a more flexible windowCollectionBehavior property so that we can fiddle with any of the behaviors. I was thinking of implementing it something like the decorations with a list that is parsed although I guess it could be an array of booleans... any thoughts welcome on that.
The next question is whether it's reasonable to update the fullscreen property to the modern meaning of fullscreen on a mac depending on the value of the windowCollectionBehavior. I think it is, however, it presents a further issue because currently switching to/from fullscreen mode re-opens the window rather than changing its properties. I strongly suspect that will break the animation even if we toggle to fullscreen in the new window. I'm guessing you don't want to add a platform specific ifdef here because all that should be handled by the platform api.
In both cases (toggle to fullscreen via script and via user clicking the widget) we probably need to handle the fullscreen mode etc and it looks from the comments that Ian added the re-open window because of fullscreen mode.
Anyway, any thoughts on this would be appreciated.
Cheers
Monte
I've been looking at what needs to be done to implement fullscreen mode on mac as a hacktoberfest contribution. At first I was just thinking about adding a fullscreenControl property but then I realised it probably should be a decoration. Now I've come to the conclusion that it would be better to implement a more flexible windowCollectionBehavior property so that we can fiddle with any of the behaviors. I was thinking of implementing it something like the decorations with a list that is parsed although I guess it could be an array of booleans... any thoughts welcome on that.
The next question is whether it's reasonable to update the fullscreen property to the modern meaning of fullscreen on a mac depending on the value of the windowCollectionBehavior. I think it is, however, it presents a further issue because currently switching to/from fullscreen mode re-opens the window rather than changing its properties. I strongly suspect that will break the animation even if we toggle to fullscreen in the new window. I'm guessing you don't want to add a platform specific ifdef here because all that should be handled by the platform api.
In both cases (toggle to fullscreen via script and via user clicking the widget) we probably need to handle the fullscreen mode etc and it looks from the comments that Ian added the re-open window because of fullscreen mode.
Anyway, any thoughts on this would be appreciated.
Cheers
Monte